Re: unaccent module - two params function should be immutable - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: unaccent module - two params function should be immutable
Date
Msg-id CAFj8pRDz6cgkPYiHf8kvWvM1hG+KPtoJMg4=0ppu9mBnqGSNOg@mail.gmail.com
Whole thread Raw
In response to Re: unaccent module - two params function should be immutable  (Bruce Momjian <bruce@momjian.us>)
Responses Re: unaccent module - two params function should be immutable  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers



2013/10/8 Bruce Momjian <bruce@momjian.us>
On Tue, Oct  8, 2013 at 06:31:03PM +0200, Pavel Stehule wrote:
>
>
>
> 2013/10/8 Bruce Momjian <bruce@momjian.us>
>
>     On Tue, Sep 24, 2013 at 05:36:58PM -0400, Bruce Momjian wrote:
>     > On Tue, Sep 17, 2013 at 10:15:47AM -0400, Robert Haas wrote:
>     > > On Sat, Sep 14, 2013 at 9:42 AM, Pavel Stehule <pavel.stehule@gmail.com
>     > wrote:
>     > > >> I have developed the attached patch based on your suggestion.  I did
>     not
>     > > >> see anything in the code that would make it STABLE, except a lookup
>     of a
>     > > >> dictionary library:
>     > > >>
>     > > >>         dictOid = get_ts_dict_oid(stringToQualifiedNameList
>     ("unaccent"),
>     > > >> false);
>     > > >
>     > > > yes, it risk, but similar is with timezones, and other external data.
>     > >
>     > > That's a catalog lookup - not a reliance on external data.
>     >
>     > Sorry, I was wrong.  Only unaccent_dict() calls get_ts_dict_oid(), and
>     > we aren't changing the signature of that function.
>
>     Applied.
>
>
> nice
>
> thank you

Do we need to update any version or anything?  I didn't think so.

I am not sure - does pg_upgrade change of flag after upgrade without increasing version number?

Regards

Pavel
 

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: unaccent module - two params function should be immutable
Next
From: Bruce Momjian
Date:
Subject: Re: unaccent module - two params function should be immutable