Re: missing support of named convention for procedures - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: missing support of named convention for procedures
Date
Msg-id CAFj8pRDsc+TXtRvECLVcyAxdZFhtSx+yvmYOVY4APgO9ZzRtbw@mail.gmail.com
Whole thread Raw
In response to Re: missing support of named convention for procedures  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: missing support of named convention for procedures  (Andres Freund <andres@anarazel.de>)
Re: missing support of named convention for procedures  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
Hi

2018-03-21 8:18 GMT+01:00 Pavel Stehule <pavel.stehule@gmail.com>:


2018-03-20 17:31 GMT+01:00 Peter Eisentraut <peter.eisentraut@2ndquadrant.com>:
On 3/16/18 06:29, Pavel Stehule wrote:
> attached patch fixes it

The fix doesn't seem to work for LANGUAGE SQL procedures.  For example:

CREATE PROCEDURE ptest5(a int, b int DEFAULT 0)
LANGUAGE SQL
AS $$
INSERT INTO cp_test VALUES (a, 'foo');
INSERT INTO cp_test VALUES (b, 'bar');
$$;
CALL ptest5(a => 1, b => 2);  -- ok
CALL ptest5(b => 3, a => 4);  -- ok
CALL ptest5(5);
ERROR:  no value found for parameter 2
CONTEXT:  SQL function "ptest5" statement 2
CALL ptest5(a => 6);
ERROR:  no value found for parameter 2
CONTEXT:  SQL function "ptest5" statement 2

I'm not quite sure why this behaves differently from plpgsql.  Needs
more digging.

Do you working on this issue? Maybe tomorrow I'll have a time to look there.

attached patch should to fix it

Regards

Pavel

Regards

Pavel
 

--
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


Attachment

pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: [PATCH] Verify Checksums during Basebackups
Next
From: John Naylor
Date:
Subject: Re: WIP: a way forward on bootstrap data