Re: Schema variables - new implementation for Postgres 15 - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: Schema variables - new implementation for Postgres 15
Date
Msg-id CAFj8pRDiC=jyXs9xzzX-XXXu95nqN-0raoFQ8LU2WuWMyDd8Ag@mail.gmail.com
Whole thread Raw
In response to Re: Schema variables - new implementation for Postgres 15  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers


pá 19. 8. 2022 v 22:54 odesílatel Alvaro Herrera <alvherre@alvh.no-ip.org> napsal:
> diff --git a/src/backend/parser/parse_relation.c b/src/backend/parser/parse_relation.c
> index f6b740df0a..b3bee39457 100644
> --- a/src/backend/parser/parse_relation.c
> +++ b/src/backend/parser/parse_relation.c
> @@ -3667,8 +3667,8 @@ errorMissingColumn(ParseState *pstate,
>               ereport(ERROR,
>                               (errcode(ERRCODE_UNDEFINED_COLUMN),
>                                relname ?
> -                              errmsg("column %s.%s does not exist", relname, colname) :
> -                              errmsg("column \"%s\" does not exist", colname),
> +                              errmsg("column or variable %s.%s does not exist", relname, colname) :
> +                              errmsg("column or variable \"%s\" does not exist", colname),
>                                state->rfirst ? closestfirst ?
>                                errhint("Perhaps you meant to reference the column \"%s.%s\".",
>                                                state->rfirst->eref->aliasname, closestfirst) :

This is in your patch 12.  I wonder -- if relname is not null, then
surely this is a column and not a variable, right?  So only the second
errmsg() here should be changed, and the first one should remain as in
the original.

Yes, it should work. I changed it in today patch

Thank you for tip

Regards

Pavel
 

--
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: Schema variables - new implementation for Postgres 15
Next
From: Erik Rijkers
Date:
Subject: Re: Schema variables - new implementation for Postgres 15