> On Fri, Sep 25, 2020 at 06:43:38PM +0200, Pavel Stehule wrote: > > I checked this set of patches and it looks well. > > I have only one minor comment. I understand the error message, but I am not > sure if without deeper knowledge I can understand. > > +update test_jsonb_subscript set test_json[-8] = 1; > +ERROR: path element at position 1 is out of range: -8 > > Maybe 'value of subscript "-8" is out of range'. Current error message is > fully correct - but people probably have to think "what is a path element > at position 1?" It doesn't look intuitive. > > Do you have some idea?
Interesting question. I've borrowed this error message format from other parts of setPath function where it appears couple of times and unfortunately can't suggest anything better. In case it this patch will get lucky enough to attract someone else, maybe we can leave it to a committer, what do you think?
ok
> My comment is minor, and I mark this patch with pleasure as ready for > committer. > > patching and compiling - without problems > implemented functionality - I like it > Building doc - without problems > make check-world - passed
