> > What happens if the message contains non-ASCII characters, and the sending backend is connected to database that uses a different encoding than the backend being signaled? > > In the current state of the patch, instead of the message you get: > > FATAL: character with byte sequence 0xe3 0x82 0xbd in encoding "UTF8" has > no equivalent in encoding “ISO_8859_5" > > Where this code fails? Isn't somewhere upper where string literals are translated? Then this message is ok.
This happens for example when a UTF-8 backend sends a message with japanese characters to a backend using ISO_8859_5. So the code works as expected, but it’s not a very good user experience.
It is same like any other using of string literal.
Personally, I don't think so these functions should be a exception.