Re: Deparsing rewritten query - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: Deparsing rewritten query
Date
Msg-id CAFj8pRCzdbPJkUOP6e-mci=Vo91FqBOLvYsiJWAaVkEXGyJb5Q@mail.gmail.com
Whole thread Raw
In response to Re: Deparsing rewritten query  (Gilles Darold <gilles@darold.net>)
Responses Re: Deparsing rewritten query
List pgsql-hackers
Hi

po 31. 1. 2022 v 15:37 odesílatel Gilles Darold <gilles@darold.net> napsal:
Le 28/06/2021 à 18:41, Julien Rouhaud a écrit :
> Thanks for the feedback Gilles!
>
> On Mon, Jun 28, 2021 at 04:06:54PM +0200, Gilles Darold wrote:
>> If we could at least call get_query_def()through an extension if we didn't
>> have a functionit would be ideal for DBAs.I agree this is unusual but when
>> it does happen to you being able to call get_query_def () helps a lot.
> Since at least 2 other persons seems to be interested in that feature, I can
> take care of writing and maintaining such an extension, provided that the
> required infrastructure is available in core.
>
> PFA v2 of the patch which only adds the required alias and expose
> get_query_def().

I checked the last patch.  I think it is almost trivial. I miss just comment, why this alias is necessary

+ if (!rte->alias)
+ rte->alias = makeAlias(get_rel_name(rte->relid), NULL);

Regards

Pavel




Thanks a lot Julien, such facilities are really helpful for DBAs and
make the difference with other RDBMS. I don't think that this feature
exists else where.


--
Gilles Darold
http://www.darold.net/






pgsql-hackers by date:

Previous
From: Mark Dilger
Date:
Subject: Re: CREATEROLE and role ownership hierarchies
Next
From: Andres Freund
Date:
Subject: Re: plperl on windows