Home > mailing lists

Re: Proposal: SET ROLE hook - Mailing list pgsql-hackers

From	Pavel Stehule
Subject	Re: Proposal: SET ROLE hook
Date	January 6, 2016 13:39:56
Msg-id	CAFj8pRCvXpWYR8VWEjcBsMo0dcV7cTboXHFA6DW9RYVNhZs6jg@mail.gmail.com Whole thread Raw
In response to	Proposal: SET ROLE hook (Joe Conway <mail@joeconway.com>)
Responses	Re: Proposal: SET ROLE hook (Joe Conway <mail@joeconway.com>)
List	pgsql-hackers

I did a review of this patch.

1. the proposal is clean and there are not any objection against it. I checked a implementation, and it does exactly same what was proposed.

2. This hook has impact only on SET role to XXX statement, what isn't used in our critical path, so there are not any performance impact

3. I was able to apply patch cleanly without any problems, warnings.

4. All regress tests was passed

5. there are not tests and documentation, but it is usual for any hook

I have not any objection

I'll mark this patch as ready for commiter

Regards

Pavel

From: "Shulgin, Oleksandr"
Date: 06 January 2016, 13:38:38
Subject: Re: Inconsistent error handling in START_REPLICATION command

From: Konstantin Knizhnik
Date: 06 January 2016, 14:16:28
Subject: Re: Optimizer questions