Re: dropdb --force - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: dropdb --force
Date
Msg-id CAFj8pRCk1YSq96XWjytn8D1pZq9uyx4zN9dGQF6qBmyBT5XeYg@mail.gmail.com
Whole thread Raw
In response to Re: dropdb --force  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: dropdb --force  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers


pá 8. 11. 2019 v 6:40 odesílatel Pavel Stehule <pavel.stehule@gmail.com> napsal:


pá 8. 11. 2019 v 6:39 odesílatel Amit Kapila <amit.kapila16@gmail.com> napsal:
On Thu, Nov 7, 2019 at 11:29 AM Pavel Stehule <pavel.stehule@gmail.com> wrote:
> čt 7. 11. 2019 v 6:56 odesílatel Amit Kapila <amit.kapila16@gmail.com> napsal:
>>
>> Okay, no problem.  I will pick the previous version and do this.  I
>> will post the patch in a day or so for your review.
>
>
> Thank you very much
>

Did you get a chance to look at the other related patch posted by me
[1]?  I have asked it before as well because I think that need to go
before this.  We need to avoid errors to happen after terminating the
connections as otherwise, the termination of other databases will go
be of no use.

I have added the comment and changed one condition in tab-completion
as otherwise, it was allowing tab completion for the following syntax:
"drop database db1 , FORCE" which doesn't make sense to me.  Please,
find the result attached.  Let me know what you think?

[1] - https://www.postgresql.org/message-id/CAA4eK1%2BqhLkCYG2oy9xug9ur_j%3DG2wQNRYAyd%2B-kZfZ1z42pLw%40mail.gmail.com

I'll check it today

I checked it for 800 active clients, and it is working without problems. I run "check-world" without problem too.

The patch looks well, I have not any comments.

Regards

Pavel


Pavel


--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Mahendra Singh
Date:
Subject: Re: [HACKERS] Block level parallel vacuum
Next
From: Amit Kapila
Date:
Subject: Re: dropdb --force