Re: Schema variables - new implementation for Postgres 15 - Mailing list pgsql-hackers

Hi,

On Thu, Jul 21, 2022 at 09:09:47AM +0200, Erik Rijkers wrote:
> On 7/21/22 08:16, Pavel Stehule wrote:
> > Hi
> >
> > new update of session variable;s implementation
> >
> > - fresh rebase
> > - new possibility to trace execution with DEBUG1 notification
> > - new SRF function pg_debug_show_used_session_variables that returns
> > content of sessionvars hashtab
> > - redesign of work with list of variables for reset, recheck, on commit
> > drop, on commit reset

Thanks for working on those!  I will keep reviewing the patchset.

> I don't know exactly what failed but the docs (html/pdf) don't build:
>
> cd ~/pg_stuff/pg_sandbox/pgsql.schema_variables/doc/src/sgml
>
> $ make html
> /usr/bin/xmllint --path . --noout --valid postgres.sgml
> postgres.sgml:374: element link: validity error : IDREF attribute linkend
> references an unknown ID "catalog-pg-variable"
> make: *** [Makefile:135: html-stamp] Error 4

Apparently most of the changes in catalogs.sgml didn't survive the last rebase.
I do see the needed section in v20220709-0012-documentation.patch:

> + <sect1 id="catalog-pg-variable">
> +  <title><structname>pg_variable</structname></title>
> [...]