Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] pgbench - allow to store select results into variables - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: [HACKERS] pgbench - allow to store select results into variables
Date
Msg-id CAFj8pRCGNRALRm6r2n-9iZQENJ92J3Hm=17mwXKeERXuNuAq7g@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] pgbench - allow to store select results intovariables  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: [HACKERS] pgbench - allow to store select results intovariables
List pgsql-hackers
Tree view
Hi

2017-10-20 18:37 GMT+02:00 Fabien COELHO <coelho@cri.ensmp.fr>:

Here is a v12.

Here is a v13, which is just a rebase after the documentation xml-ization.

I am looking to this patch.

Not sure if "cset" is best name - maybe "eset" .. like embeded set?

The code of append_sql_command is not too readable and is not enough commented.

I don't understand why you pass a param compounds to append_sql_command, when this value is stored in my_command->compound from create_sql_command?

Or maybe some unhappy field or variable names was chosen.

Regards

Pavel

--
Fabien.

pgsql-hackers by date:

Previous
From: Beena Emerson
Date:
Subject: Re: [HACKERS] path toward faster partition pruning
Next
From: Anthony Bykov
Date:
Subject: [HACKERS] Jsonb transform for pl/python