Re: proposal: possibility to read dumped table's name from file - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: proposal: possibility to read dumped table's name from file
Date
Msg-id CAFj8pRCCJ1vqDREwK41tbRX8k96VSAWFe9uOCCAmLJ8cwJC4Vw@mail.gmail.com
Whole thread Raw
In response to Re: proposal: possibility to read dumped table's name from file  (Justin Pryzby <pryzby@telsasoft.com>)
Responses Re: proposal: possibility to read dumped table's name from file
List pgsql-hackers


ne 5. 7. 2020 v 22:31 odesílatel Justin Pryzby <pryzby@telsasoft.com> napsal:
On Wed, Jul 01, 2020 at 04:24:52PM -0500, Justin Pryzby wrote:
> On Thu, Jun 11, 2020 at 09:36:18AM +0200, Pavel Stehule wrote:
> > st 10. 6. 2020 v 0:30 odesílatel Justin Pryzby <pryzby@telsasoft.com> napsal:
> > > > +                                             /* ignore empty rows */
> > > > +                                             if (*line != '\0')
> > >
> > > Maybe: if line=='\0': continue
> > > We should also support comments.
>
> Comment support is still missing but easily added :)

Still missing from the latest patch.

I can implement a comment support. But I am not sure about the format. The start can be "--" or classic #.

but "--" can be in this context messy



With some added documentation, I think this can be RfC.

--
Justin

pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: [Patch] Invalid permission check in pg_stats for functional indexes
Next
From: Daniel Gustafsson
Date:
Subject: Re: Binary support for pgoutput plugin