Postgres Pro
Downloads
Home   >   mailing lists

Re: Function array_agg(array) - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: Function array_agg(array)
Date
Msg-id CAFj8pRC5uT_5XXm6D_YWXzMPEh7yFfNKrOc3_vXYWF_Wd0gEYA@mail.gmail.com
Whole thread Raw
In response to Re: Function array_agg(array)  (Ali Akbar <the.apaan@gmail.com>)
Responses Re: Function array_agg(array)
List pgsql-hackers
Tree view
Hi

I did some minor changes in code

* move tests of old or new builder style for array sublink out of main cycles
* some API simplification of new builder - we should not to create identical API, mainly it has no sense

Regards

Pavel Stehule


2014-10-27 8:12 GMT+01:00 Ali Akbar <the.apaan@gmail.com>:
2014-10-27 9:11 GMT+07:00 Ali Akbar <the.apaan@gmail.com>:

2014-10-27 1:38 GMT+07:00 Pavel Stehule <pavel.stehule@gmail.com>:
Hi

My idea is using new ArrayBuilder optimized for building multidimensional arrays with own State type. I think so casting to ArrayBuildState is base of our problems, so I don't would to do. Code in array_agg_* is simple, little bit more complex code is in nodeSubplan.c. Some schematic changes are in attachments.

Thanks! The structure looks clear, and thanks for the example on nodeSubplan.c. I will restructure the v10 of the patch to this structure.

Patch attached.

Regards, 
--
Ali Akbar

Attachment

pgsql-hackers by date:

Previous
From: "Amit Langote"
Date:
Subject: Re: On partitioning
Next
From: Alvaro Herrera
Date:
Subject: Re: On partitioning