po 18. 3. 2019 v 21:23 odesílatel Tom Lane <tgl@sss.pgh.pa.us> napsal:
Alexander Korotkov <a.korotkov@postgrespro.ru> writes: > On Mon, Mar 18, 2019 at 10:08 PM Tom Lane <tgl@sss.pgh.pa.us> wrote: >> Just another minor bitch about this patch: jsonpath_scan.l has introduced >> a typedef called "keyword". This is causing pgindent to produce seriously >> ugly results in libpq, and probably in other places where that is used as >> a field or variable name. Please rename that typedef to something less >> generic.
> Ooops... I propose to rename it to KeyWord, which is already > typedef'ed in formatting.c. See the attached patch. Is it OK?
I had in mind JsonPathKeyword or something like that. If you re-use formatting.c's typedef name, pgindent won't care, but it's possible you'd be in for unhappiness when trying to look at these structs in gdb for instance.
