Re: proposal: searching in array function - array_position - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: proposal: searching in array function - array_position
Date
Msg-id CAFj8pRBeBapPz5eSi7v2arQbt8txMaL88-fcCrdgjw20wwQitA@mail.gmail.com
Whole thread Raw
In response to Re: proposal: searching in array function - array_position  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: proposal: searching in array function - array_position
List pgsql-hackers
Hi

here is updated patch with array_position, array_positions implementation.

It is based on committed code - so please, revert commit 13dbc7a824b3f905904cab51840d37f31a07a9ef and apply this patch

Regards

Pavel


2015-03-20 18:29 GMT+01:00 Alvaro Herrera <alvherre@2ndquadrant.com>:
Pavel Stehule wrote:
> 2015-03-20 17:49 GMT+01:00 Dean Rasheed <dean.a.rasheed@gmail.com>:
>
> > There's an issue when the array's lower bound isn't 1:
> >
> > select array_offset('[2:4]={1,2,3}'::int[], 1);
> >  array_offset
> > --------------
> >             1
> > (1 row)
> >
> > whereas I would expect this to return 2. Similarly for
> > array_offsets(), so the offsets can be used as indexes into the
> > original array.
> >
>
> I am thinking, so it is ok - it returns a offset, not position.

So you can't use it as a subscript?  That sounds unfriendly.  Almost
every function using this will be subtly broken.

--
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Zero-padding and zero-masking fixes for to_char(float)
Next
From: David Rowley
Date:
Subject: Re: Performance improvement for joins where outer side is unique