Re: [HACKERS] patch: function xmltable - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: [HACKERS] patch: function xmltable
Date
Msg-id CAFj8pRBYzyGLNq7rmbrE=Jx60ku6yEdtNRwojN9qPmLvcSJFxQ@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] patch: function xmltable  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: [HACKERS] patch: function xmltable  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Hi

2017-02-16 6:38 GMT+01:00 Pavel Stehule <pavel.stehule@gmail.com>:
Hi


please see attached patch

* enhanced regress tests
* clean memory context work

new update 

fix a bug in string compare
fix some typo and obsolete comments

Regards

some minor but interesting fix.

I found so some xml values imported via recv function can have inconsistency between header encoding and used encoding. Internally the header encoding is removed - see xml_out function. 

So now, when I have to prepare data for libxml2, I don't do direct cast, but I use xml_out_internal instead. Maybe this technique should be used elsewhere? Same issue I see on xpath function.

Solved issue is not too often probably - the some different encoding than utf8 should be used in XML document and XML document should be loaded with recv function.

Regards

Pavel

 

Pavel
 

Regards

Pavel
 

--
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



Attachment

pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: [HACKERS] Should we cacheline align PGXACT?
Next
From: Masahiko Sawada
Date:
Subject: Re: [HACKERS] GUC for cleanup indexes threshold.