Re: proposal: plpgsql - Assert statement - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: proposal: plpgsql - Assert statement
Date
Msg-id CAFj8pRBW1Fx132NxT=xuedWJmaxScdcMpMvTre=pMPGRZmE1fg@mail.gmail.com
Whole thread Raw
In response to Re: proposal: plpgsql - Assert statement  (Petr Jelinek <petr@2ndquadrant.com>)
Responses Re: proposal: plpgsql - Assert statement
List pgsql-hackers


2014-10-17 9:14 GMT+02:00 Petr Jelinek <petr@2ndquadrant.com>:
On 16/10/14 13:29, Pavel Stehule wrote:
Hi

2014-10-14 22:57 GMT+02:00 Petr Jelinek <petr@2ndquadrant.com

    Short review of the patch. Note that this has nothing to do with
    actual assertions, at the moment it's just enhancement of RAISE
    statement to make it optionally conditional. As I was one of the
    people who voted for it I do think we want this and I like the syntax.

    Code applies cleanly, seems formatted according to project standards
    - there is unnecessary whitespace added in variable declaration part
    of exec_stmt_raise which should be removed.


fixed


    Passes make check, I would prefer to have little more complex
    expression than just "true" in the new regression test added for
    this feature.


fixed


    Did some manual testing, seems to work as advertised.

    There are no docs at the moment which is the only show-stopper that
    I can see so far.


fixed


Great, looks good to me, marking as ready for committer.

Thank you very much

Pavel
 


--
 Petr Jelinek                  http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: CREATE POLICY and RETURNING
Next
From: Michael Paquier
Date:
Subject: Re: [PATCH] add ssl_protocols configuration option