Re: proposal: function parse_ident - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: proposal: function parse_ident
Date
Msg-id CAFj8pRBUk8+ezdv77bDso4jaYcoGMcKL2MLHK+3tjPV68kgr9g@mail.gmail.com
Whole thread Raw
In response to Re: proposal: function parse_ident  (Teodor Sigaev <teodor@sigaev.ru>)
List pgsql-hackers


2016-03-14 17:39 GMT+01:00 Teodor Sigaev <teodor@sigaev.ru>:
I afraid so I cannot to fix this inconsistency (if this is inconsistency - the
binary values are same) - the parameter of function is raw string with processed
escape codes, and I have not any information about original escape sequences.
When you enter octet value, and I show it as hex value, then there should be
difference. Buy I have not information about your input (octet or hex). I have
the original string of SQL identifier inside parser, executor, but I have not
original string of function parameter inside function (not without pretty
complex and long code).
Ok, agree


I am trying describe it in doc (I am sorry for my less level English) in new
patch. Fixed duplicated oid too.
Edited a bit + fix some typos and remove unneeded headers, patch attached

Sorry, I can't find all corner-cases at once, but:
SELECT parse_ident(E'"c".X XXXXXXXXXX');
ERROR:  identifier contains disallowed characters: "\"c"

I'll check it tomorrow

Thank you

Pavel
 

Error message wrongly points to the reason of error.





--
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
                                                   WWW: http://www.sigaev.ru/

pgsql-hackers by date:

Previous
From: David Steele
Date:
Subject: Re: pgbench stats per script & other stuff
Next
From: David Steele
Date:
Subject: Re: [PATCH] Supporting +-Infinity values by to_timestamp(float8)