Re: Fwd: patch: make_timestamp function - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: Fwd: patch: make_timestamp function
Date
Msg-id CAFj8pRBPautQ2zRn6czRkN7gPcBFovb6UTg1HjiLt3nrunA6ZA@mail.gmail.com
Whole thread Raw
In response to Re: Fwd: patch: make_timestamp function  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: Fwd: patch: make_timestamp function  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Hello

updated version - a precheck is very simple, and I what I tested it is enough

Regards

Pavel




2014-02-28 15:11 GMT+01:00 Alvaro Herrera <alvherre@2ndquadrant.com>:
Pavel Stehule escribió:

> so still I prefer to allow numeric time zones.
>
> What I can:
>
> a) disallow numeric only timezone without prefix "+" or "-"
>
> or
>
> b) add "+" prefix to time zone, when number is possitive.
>
> I prefer @a.

I can live with (a) too.  But I wonder if we should restrict the allowed
tz even further, for example to say that there must always be either 2
digits (no colon) or 4 digits, with or without a colon.

--
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: ALTER TABLE lock strength reduction patch is unsafe
Next
From: Antonin Houska
Date:
Subject: Re: Equivalence Rules