Re: pgsql: Introduce hash_search_with_hash_value() function - Mailing list pgsql-committers

I tried to use hash_seq_init_with_hash_value in session variables patch, but it doesn't work there.

<-->if (!sessionvars)
<--><-->return;

elog(NOTICE, "%u", hashvalue);


<-->hash_seq_init(&status, sessionvars);

<-->while ((svar = (SVariable) hash_seq_search(&status)) != NULL)
<-->{
<--><-->if (hashvalue == 0 || svar->hashvalue == hashvalue)
<--><-->{
<--><--><-->elog(NOTICE, "FOUND OLD");
<--><--><-->svar->is_valid = false;
<--><-->}
<-->}



<-->/*
<--> * If the hashvalue is not specified, we have to recheck all currently
<--> * used session variables.  Since we can't tell the exact session variable
<--> * from its hashvalue, we have to iterate over all items in the hash bucket.
<--> */
<-->if (hashvalue == 0)
<--><-->hash_seq_init(&status, sessionvars);
<-->else
<--><-->hash_seq_init_with_hash_value(&status, sessionvars, hashvalue);

<-->while ((svar = (SVariable) hash_seq_search(&status)) != NULL)
<-->{
<--><-->Assert(hashvalue == 0 || svar->hashvalue == hashvalue);

elog(NOTICE, "found");

<--><-->svar->is_valid = false;
<--><-->needs_validation = true;
<-->}
}

Old methods found an entry, but new not.

What am I doing wrong?

Regards

Pavel