Re: Proposal: SET ROLE hook - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: Proposal: SET ROLE hook
Date
Msg-id CAFj8pRBKHqhX=JRC6YHvhFpWy1HZ9h1+RrDqY_hQf=ndRkHy2w@mail.gmail.com
Whole thread Raw
In response to Re: Proposal: SET ROLE hook  (Joe Conway <mail@joeconway.com>)
Responses Re: Proposal: SET ROLE hook
List pgsql-hackers
Hi

2016-02-29 2:40 GMT+01:00 Joe Conway <mail@joeconway.com>:
On 01/07/2016 09:08 AM, Joe Conway wrote:
> On 01/06/2016 10:36 AM, Tom Lane wrote:
>> I think a design that was actually somewhat robust would require two
>> hooks, one at check_role and one at assign_role, wherein the first one
>> would do any potentially-failing work and package all required info into
>> a blob that could be passed through to the assign hook.

Attached.

These patches are pretty trivial, and I can confirm so all regress tests are passed.

I see following issues:

1. Missing the possibility to pass custom data from SetRoleCheck_hook to SetRoleAssign_hook. Tom mentioned it in his comment.

2. Missing little bit more comments and an explanation why and when to use these hooks.

Regards

Pavel


 

Joe

--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development

Attachment

pgsql-hackers by date:

Previous
From: Stas Kelvich
Date:
Subject: transam README small fix
Next
From: Amit Kapila
Date:
Subject: Re: Relation extension scalability