Postgres Pro
Downloads
Home   >   mailing lists

Re: strip nulls functions for json and jsonb - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: strip nulls functions for json and jsonb
Date
Msg-id CAFj8pRB2Xa=wxy_Eh_2DnLr05W1vGP+TwTGH5ueYOenJnYQ6aQ@mail.gmail.com
Whole thread Raw
In response to strip nulls functions for json and jsonb  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: strip nulls functions for json and jsonb
List pgsql-hackers
Tree view
Hello

I checked this patch.

1. There is a consensus we want this feature.

2. This patch implement just this mentioned feature. There is no objection against design.
 
3. It is possible to apply this patch and compile without warnings.

4. I tested null stripping on large json, jsonb values without problems.

5. regress tests are enough

6. code is well formatted


Objections & questions:

1. missing documentation

2. I miss more comments related to this functions. This code is relative simple, but some more explanation can be welcome.

3. why these functions are marked as "stable"?

Regards

Pavel



2014-10-04 1:23 GMT+02:00 Andrew Dunstan <andrew@dunslane.net>:
As discussed recently, here is an undocumented patch for json_strip_nulls and jsonb_strip_nulls.

cheers

andrew


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: TODO : Allow parallel cores to be used by vacuumdb [ WIP ]
Next
From: Robert Haas
Date:
Subject: Re: WIP: dynahash replacement for buffer table