review: WITH CHECK OPTION - Mailing list pgsql-hackers

From Pavel Stehule
Subject review: WITH CHECK OPTION
Date
Msg-id CAFj8pRAr11OEtfLutBHhuk9Px5XBX5Euq9hixpZut7EBiOGWrg@mail.gmail.com
Whole thread Raw
List pgsql-hackers
Hello

0) we would this feature
* it is finalization of ANSI SQL feature, that is complete now
* it is useful feature, than moves work with updatable views close to heaps

1) patch is cleanly applied
2) there are no new warnings
3) all regress tests was passed - there are enough tests for this feature
4) doc was rebuilt without problems and it is well documented
5) a implemented feature is ANSI SQL compliant
6) code is clean, well commented and well formatted
7) it works as expected

This patch is ready for commit

Regards

Pavel Stehule



pgsql-hackers by date:

Previous
From: Claudio Freire
Date:
Subject: Re: [PATCH] Fix conversion for Decimal arguments in plpython functions
Next
From: Michael Paquier
Date:
Subject: Re: Changing recovery.conf parameters into GUCs