Hi
I am doing an review of this patch and I have two comments
1. I am not sure if get_call_trftypes is a good name - the prefix get_call is used when some runtime data is processed. This function just returns reformatted data from the system catalogue. Maybe get_func_trftypes_list, or just replace function get_func_trftypes (now, the list is an array, so there should not be performance issues). For consistency, the new function should be used in plperl and plpython too. Probably this function is not widely used, so I don't see why we need to have two almost equal functions in code.
2.
+ It also contains the OID of the intended procedural language and whether
+ that procedural language is declared as <literal>TRUSTED</literal>, useful
+ if a single inline handler is supporting more than one procedural language.
I am not sure if this sentence is in the correct place. Maybe can be mentioned separately,
so generally handlers can be used by more than one procedural language. But maybe
I don't understand this sentence.
Regards
Pavel
