Postgres Pro
Downloads
Home   >   mailing lists

Re: PATCH: pgbench allow '=' in \set - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: PATCH: pgbench allow '=' in \set
Date
Msg-id CAFj8pRAnzWezEufM67qNESFAi=7y0NeK5Rpn_2k5=hs73jg=PQ@mail.gmail.com
Whole thread Raw
In response to PATCH: pgbench allow '=' in \set  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: PATCH: pgbench allow '=' in \set
Re: PATCH: pgbench allow '=' in \set
List pgsql-hackers
Tree view


2015-05-07 20:18 GMT+02:00 Fabien COELHO <coelho@cri.ensmp.fr>:

Hello devs,

Since an expression syntax has been added to pgbench, I find that the readability of expressions is not great. An extra '=' improves the situation for me:

   \set id = 1 + abs((:id * 1021) % (100000 * :scale))

seems slightly better than:

   \set id 1 + abs((:id * 1021) % (100000 * :scale))

But that is debatable!

The attached patch just ignores a leading '=' in a pgbench expression.

It is question :( - it break a consistency with psql

Regards

Pavel
 

--
Fabien.

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: EvalPlanQual behaves oddly for FDW queries involving system columns
Next
From: Andres Freund
Date:
Subject: Re: INSERT ... ON CONFLICT error messages