Re: [HACKERS] proposal psql \gdesc - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: [HACKERS] proposal psql \gdesc
Date
Msg-id CAFj8pRAjUUpqrRtm6vG5uzPBDsz9a40vtVW70OdxL7RS5ib2eQ@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] proposal psql \gdesc  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: [HACKERS] proposal psql \gdesc  (Fabien COELHO <coelho@cri.ensmp.fr>)
Re: [HACKERS] proposal psql \gdesc  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-hackers


2017-05-20 22:26 GMT+02:00 Fabien COELHO <coelho@cri.ensmp.fr>:

Hello Pavel,

 - Maybe tests could also exercise unnamed columns, eg:
    SELECT 1, 2, 3 \gdesc \g

done

Can't see it. No big deal, but if you put it it did not get through, and there is a warning with git apply on the very last line of the patch which may be linked to that:

  psql-gdesc-05.patch:328: new blank line at EOF.
  +
  warning: 1 line adds whitespace errors.

looks like pg_regress issue - more result files has extra blank line on end. I am able to clean it only with \r on end of sql script - not sure what is more worst - unrelated \command or this warning

 

... especially as the two last tests are nearly the same now. I'm fine with a "one line" test, could be with some unnamed columns so that it is more different?

ok - look on  new version, please
 


--
Fabien.

Attachment

pgsql-hackers by date:

Previous
From: "MauMau"
Date:
Subject: [HACKERS] [Q] When should I use reg* types instead of oid in the system catalog?
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] [Q] When should I use reg* types instead of oid in the system catalog?