Re: [HACKERS] pgbench - use enum for meta commands - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: [HACKERS] pgbench - use enum for meta commands
Date
Msg-id CAFj8pRAeuGDftBbezDDgVWAgesbiz5OAUz8azid+tBAK_x1n5w@mail.gmail.com
Whole thread Raw
In response to [HACKERS] pgbench - use enum for meta commands  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-hackers


2017-09-23 5:45 GMT+02:00 Fabien COELHO <coelho@cri.ensmp.fr>:

Minor code enhancement.

While having a look at adding if/elif/else/endif to pgbench, and given the current gset/cset added meta commands in cf queue, it occured to me that repeated string comparisons to check for the various meta commands is neither efficient nor readable. Use an enum instead, which are extensively used already for other similar purposes.

+1

Pavel


--
Fabien.


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] CREATE COLLATION does not sanitize ICU's BCP 47 language tags. Should it?
Next
From: Peter Geoghegan
Date:
Subject: Re: [HACKERS] CREATE COLLATION does not sanitize ICU's BCP 47language tags. Should it?