Re: patch: function xmltable - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: patch: function xmltable
Date
Msg-id CAFj8pRAbLOLBUA--8zEBdDTCgV=GW5A080YCceDJwkxrKo0thA@mail.gmail.com
Whole thread Raw
In response to Re: patch: function xmltable  (Craig Ringer <craig@2ndquadrant.com>)
List pgsql-hackers
Hi

2016-09-23 10:07 GMT+02:00 Craig Ringer <craig@2ndquadrant.com>:
> Did some docs copy-editing and integrated some examples.

Whoops, forgot to attach.

Rather than sending a whole new copy of the patch, here's a diff
against your patched tree of my changes so you can see what I've done
and apply the parts you want.

Note that I didn't updated the expected files.

I applied your patch - there is small misunderstanding. The PATH is evaluated once for input row already. It is not clean in code, because it is executor node started and running for all rows. I changed it in your part of doc.

   to a simple value before calling the function. <literal>PATH</>
+      expressions are normally evaluated <emphasis>exactly once per result row ## per input row
+      </emphasis>,

Regards

Pavel
 

--
 Craig Ringer                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Hash Indexes
Next
From: Tom Lane
Date:
Subject: PG 9.6.0 release schedule