Re: [HACKERS] proposal: psql command \graw - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: [HACKERS] proposal: psql command \graw
Date
Msg-id CAFj8pRAOAXZfCmFtgZ+Fb9goc-AkMhNU1DjeN59v=VB9bnwu6A@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] proposal: psql command \graw  (Pavel Stehule <pavel.stehule@gmail.com>)
List pgsql-hackers


2017-11-09 21:12 GMT+01:00 Pavel Stehule <pavel.stehule@gmail.com>:


2017-11-09 21:03 GMT+01:00 Fabien COELHO <coelho@cri.ensmp.fr>:

Hello Pavel,

I hope so I fixed all mentioned issues.

Patch applies with a warning:

 > git apply ~/psql-graw-2.patch
 /home/fabien/psql-graw-2.patch:192: new blank line at EOF.
 +
 warning: 1 line adds whitespace errors.

Otherwise it compiles. "make check" ok. doc gen ok.

Two spurious empty lines are added before StoreQueryTuple.

Doc: "If <literal>+</literal> is appended to the command name, a column names are displayed."

I suggest instead: "When <literal>+</literal> is appended, column names are also displayed."

ISTM that you can remove "force_column_header" and just set "tuple_only" to what you need, that is you do not need to change anything in function "print_unaligned_text".

Last point is not possible - I would not to break original tuple only mode.


updated patch


 
Pavel

--
Fabien.


Attachment

pgsql-hackers by date:

Previous
From: Kyotaro HORIGUCHI
Date:
Subject: Re: [HACKERS] path toward faster partition pruning
Next
From: Kyotaro HORIGUCHI
Date:
Subject: Re: [HACKERS] path toward faster partition pruning