Re: pl/pgsql feature request: shorthand for argument and local variable references - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: pl/pgsql feature request: shorthand for argument and local variable references
Date
Msg-id CAFj8pRAJyepF06WYiRUmkz4Qr5jrC3EyXYUa5xX4C5vsQWg8DQ@mail.gmail.com
Whole thread Raw
In response to Re: pl/pgsql feature request: shorthand for argument and local variable references  (Michael Paquier <michael@paquier.xyz>)
Responses Re: pl/pgsql feature request: shorthand for argument and local variable references  (Erik Rijkers <er@xs4all.nl>)
Re: pl/pgsql feature request: shorthand for argument and local variable references  (Julien Rouhaud <rjuju123@gmail.com>)
List pgsql-hackers


st 17. 3. 2021 v 23:32 odesílatel Michael Paquier <michael@paquier.xyz> napsal:
On Wed, Mar 17, 2021 at 05:04:48PM +0100, Pavel Stehule wrote:
> This tree has a different direction than is usual, and then replacing the
> root node is not simple.

Yeah, it is not like we should redesign this whole part just for the
feature discussed here, and that may impact performance as the current
list handling is cheap now.

> Second solution (significantly more simple) is an additional pointer in
> ns_item structure. In almost all cases this pointer will not be used.
> Because ns_item uses a flexible array, then union cannot be used. I
> implemented this in a patch marked as "alias-implementation".
>
> What do you think about it?

I am not sure that it is necessary nor good to replace entirely the
root label.  So associating a new field directly into it sounds like a
promising approach?

Here is rebased patch

I am continuing to  talk with Hannu about syntax. I think so using the compile option is a good direction, but maybe renaming from "routine_label" to "topscope_label" (proposed by Hannu) or maybe "outerscope_label" can be a good idea.

Regards

Pavel


--
Michael
Attachment

pgsql-hackers by date:

Previous
From: "Drouvot, Bertrand"
Date:
Subject: Re: Minimal logical decoding on standbys
Next
From: "tanghy.fnst@fujitsu.com"
Date:
Subject: RE: Logical Replication vs. 2PC