On Fri, Oct 07, 2022 at 07:26:08AM +0200, Pavel Stehule wrote: > > I checked this code again, and I don't think some refactoring is easy. > getFiltersFromFile is not duplicated. It is just probably badly named. > > These routines are used from pg_dump, pg_dumpall and pg_restore. There are > significant differences in supported objects and in types used for returned > lists (dumpOptions, SimpleStringList, and RestoreOptions). If I have one > routine, then I need to implement some mechanism for specification of > supported objects, and a special type that can be used as a proxy between > caller and parser to hold lists of parsed values. To be names less > confusing I renamed them to read_dump_filters, read_dumpall_filters and > read_restore_filters
Ah right, I missed the different argument types. Now that the functions have improved names it looks way clearer, and it seems just fine!
