Re: possible proposal plpgsql GET DIAGNOSTICS oid = PG_ROUTINE_OID - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: possible proposal plpgsql GET DIAGNOSTICS oid = PG_ROUTINE_OID
Date
Msg-id CAFj8pRA0w3aOwnzuT8Cj=qWQTJZVSZ5bA9xo7TRFJ7Dup_Ya2Q@mail.gmail.com
Whole thread Raw
In response to Re: possible proposal plpgsql GET DIAGNOSTICS oid = PG_ROUTINE_OID  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: possible proposal plpgsql GET DIAGNOSTICS oid = PG_ROUTINE_OID
List pgsql-hackers
Hi


po 3. 4. 2023 v 19:37 odesílatel Tom Lane <tgl@sss.pgh.pa.us> napsal:
Pavel Stehule <pavel.stehule@gmail.com> writes:
> po 27. 3. 2023 v 5:36 odesílatel Kirk Wolak <wolakk@gmail.com> napsal:
>> I have marked the item Ready for Commiter...

> Thank you for doc and for review

I'm kind of surprised there was any interest in this proposal at all,
TBH, but apparently there is some.  Still, I think you over-engineered
it by doing more than the original proposal of making the function OID
available.  The other things can be had by casting the OID to regproc
or regprocedure, so I'd be inclined to add just one new keyword not
three.  Besides, your implementation is a bit inconsistent: relying
on fn_signature could return a result that is stale or doesn't conform
to the current search_path.

ok

There is reduced patch + regress tests

Regards

Pavel



                        regards, tom lane
Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [BUG] Logical replica crash if there was an error in a function.
Next
From: Anthonin Bonnefoy
Date:
Subject: [PATCH] Add statement_timeout in pg_stat_activity