Re: plpgsql_check_function - rebase for 9.3 - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: plpgsql_check_function - rebase for 9.3
Date
Msg-id CAFj8pRA09FsRLA=wSkmM0MwVBs5B5f6dLTLgYKCFzfA-1850zw@mail.gmail.com
Whole thread Raw
In response to Re: plpgsql_check_function - rebase for 9.3  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: plpgsql_check_function - rebase for 9.3
Re: plpgsql_check_function - rebase for 9.3
List pgsql-hackers



2013/12/9 Amit Kapila <amit.kapila16@gmail.com>
On Sun, Dec 8, 2013 at 10:31 PM, Pavel Stehule <pavel.stehule@gmail.com> wrote:
>
>
>
> 2013/12/8 Peter Eisentraut <peter_e@gmx.net>
>>
>> In my opinion, the idea of having a separate lint checker for a language
>> is antiquated.  If there are problems, they should be diagnosed at
>> compile time or run time.  You can add options about warning levels or
>> strictness if there are concerns about which diagnostics are
>> appropriate.
>
>
> There are two points, that should be solved
>
> a) introduction a dependency to other object in schema - now CREATE FUNCTION
> is fully independent on others
>
> b) slow start - if we check all paths on start, then start can be slower -
> and some functions should not work due dependency on temporary tables.
>
> I am thinking about possible marking a function by #option (we have same
> idea)
>
> some like
>
> #option check_on_first_start
> #option check_on_create
> #option check_newer

what exactly check_newer means, does it mean whenever a function is
replaced (changed)?


no, it means, so request for check will be ignored ever - some functions cannot be deeply checked due using dynamic SQL or dynamic created data types - temporary tables created in functions.

Regards

Pavel
 
> But still I have no idea, how to push check without possible slowdown
> execution with code duplication


With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: [bug fix] pg_ctl always uses the same event source
Next
From: KONDO Mitsumasa
Date:
Subject: Re: Why we are going to have to go DirectIO