Re: Parallel bitmap heap scan - Mailing list pgsql-hackers

From Dilip Kumar
Subject Re: Parallel bitmap heap scan
Date
Msg-id CAFiTN-vu0ykjS+u3fXiMVy5ABZPrsc=1dZKK1GQcTR8F_tBiDQ@mail.gmail.com
Whole thread Raw
In response to Re: Parallel bitmap heap scan  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Mon, Mar 27, 2017 at 5:58 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> Failing to pass DSA_ALLOC_HUGE is an obvious oversight, but I think
> the ptbase == NULL check shouldn't be needed, because we're not
> passing DSA_ALLOC_NO_OOM.  And that's good, because this is going to
> be called from SH_CREATE, which isn't prepared for a NULL return
> anyway.
>
> Am I all wet?

Yes you are right that we are not passing DSA_ALLOC_NO_OOM, so
dsa_allocate_extended will return error in case if allocation failed.


-- 
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Monitoring roles patch
Next
From: Tom Lane
Date:
Subject: Re: [COMMITTERS] pgsql: Improve access to parallel query from procedural languages.