Postgres Pro
Downloads
Home   >   mailing lists

Re: Have SIGHUP instead of SIGTERM for config reload in logical replication launcher - Mailing list pgsql-hackers

From Dilip Kumar
Subject Re: Have SIGHUP instead of SIGTERM for config reload in logical replication launcher
Date
Msg-id CAFiTN-vry=fv7fHSnEOFPu6feH_1KTXcTkYEMb-t1HOgaPw_1w@mail.gmail.com
Whole thread Raw
In response to Have SIGHUP instead of SIGTERM for config reload in logical replication launcher  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: Have SIGHUP instead of SIGTERM for config reload in logical replication launcher  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
Tree view 
On Wed, Jul 15, 2020 at 6:17 PM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
>
> Hi,
>
> In ApplyLauncherMain, it seems like we are having SIGTERM signal
> mapped for config reload. I think we should be having SIGHUP for
> SignalHandlerForConfigReload(). Otherwise we miss to take the updated
> value for wal_retrieve_retry_interval in ApplyLauncherMain.
>
> Attached is a patch having this change.
>
> Thoughts?

Yeah, it just looks like a typo so your fix looks good to me.

-- 
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Have SIGHUP instead of SIGTERM for config reload in logical replication launcher
Next
From: Magnus Hagander
Date:
Subject: Which SET TYPE don't actually require a rewrite