On Wed, Aug 3, 2022 at 7:15 AM Dilip Kumar <dilipbalaut@gmail.com> wrote: > Another version of the patch which closes the smgr at the end using > smgrcloserellocator() and I have also added a commit message.
Hmm, but didn't we decide against doing it that way intentionally? The comment you're deleting says "If we didn't do this and used the smgr layer directly, we would have to worry about invalidations."
I think we only need to worry if we keep the smgr reference around and try to reuse it. But in this patch I am not keeping the reference to the smgr.