Postgres Pro
Downloads
Home   >   mailing lists

Re: Identify missing publications from publisher while create/alter subscription. - Mailing list pgsql-hackers

From Dilip Kumar
Subject Re: Identify missing publications from publisher while create/alter subscription.
Date
Msg-id CAFiTN-vB-yy7G1ZtRKSkMpZf8xNN9mP_rxjiOojmni4CtvGAWg@mail.gmail.com
Whole thread Raw
In response to Re: Identify missing publications from publisher while create/alter subscription.  (vignesh C <vignesh21@gmail.com>)
Responses Re: Identify missing publications from publisher while create/alter subscription.
List pgsql-hackers
Tree view 
On Sun, May 2, 2021 at 10:04 PM vignesh C <vignesh21@gmail.com> wrote:
>
> Thanks for the comments.
> The Attached patch has the fixes for the same.

I was reviewing the documentation part, I think in the below paragraph
we should include validate_publication as well?

       <varlistentry>
        <term><literal>connect</literal> (<type>boolean</type>)</term>
        <listitem>
         <para>
          Specifies whether the <command>CREATE SUBSCRIPTION</command>
          should connect to the publisher at all.  Setting this to
          <literal>false</literal> will change default values of
          <literal>enabled</literal>, <literal>create_slot</literal> and
          <literal>copy_data</literal> to <literal>false</literal>.
         </para>

I will review/test the other parts of the patch and let you know.

-- 
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Logical Replication - behavior of TRUNCATE ... CASCADE
Next
From: Amit Kapila
Date:
Subject: Re: Replication slot stats misgivings