> > Yeah, that's true, but even if we are blocking the transactions from committing then also it is possible that a new connection can come and generate more WAL, yeah but I agree with the other part that if you throttle after committing then the user can cancel the queries and generate more WAL from those sessions as well. But that is an extreme case where application developers want to bypass the throttling and want to generate more WALs.
How about having the new hook at the start of the new txn? If we do this, when the limit for the throttling is exceeded, the current txn (even if it is a long running one) continues to do the WAL insertions, the next txns would get blocked. Thoughts?
Do you mean while StartTransactionCommand or while assigning a new transaction id? If it is at StartTransactionCommand then we would be blocking the sessions which are only performing read queries right? If we are doing at the transaction assignment level then we might be holding some of the locks so this might not be any better than throttling inside the commit.
