Re: Questions/Observations related to Gist vacuum - Mailing list pgsql-hackers

From Dilip Kumar
Subject Re: Questions/Observations related to Gist vacuum
Date
Msg-id CAFiTN-v0nL-KKEiqaanb=wOkSGuJ=+Dw0_3q6OaL=wLU0mCOZQ@mail.gmail.com
Whole thread Raw
In response to Re: Questions/Observations related to Gist vacuum  (Heikki Linnakangas <hlinnaka@iki.fi>)
Responses Re: Questions/Observations related to Gist vacuum  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Tue, Oct 15, 2019 at 7:13 PM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>
> On 15/10/2019 09:37, Amit Kapila wrote:
> > While reviewing a parallel vacuum patch [1], we noticed a few things
> > about $SUBJECT implemented in commit -
> > 7df159a620b760e289f1795b13542ed1b3e13b87.
> >
> > 1. A new memory context GistBulkDeleteResult->page_set_context has
> > been introduced, but it doesn't seem to be used.
>
> Oops. internal_page_set and empty_leaf_set were supposed to be allocated
> in that memory context. As things stand, we leak them until end of
> vacuum, in a multi-pass vacuum.

Here is a patch to fix this issue.

-- 
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

Attachment

pgsql-hackers by date:

Previous
From: Dave Cramer
Date:
Subject: Re: let's make the list of reportable GUCs configurable (was Re: Add%r substitution for psql prompts to show recovery status)
Next
From: Amit Kapila
Date:
Subject: Re: [HACKERS] Block level parallel vacuum