Postgres Pro
Downloads
Home   >   mailing lists

Re: Relation extension scalability - Mailing list pgsql-hackers

From Dilip Kumar
Subject Re: Relation extension scalability
Date
Msg-id CAFiTN-uUpJpvc=VkioX3ew3-OzCfhSdsB8e0Y94XpOYUy0PBpQ@mail.gmail.com
Whole thread Raw
In response to Re: Relation extension scalability  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
Tree view

On Sat, Jan 23, 2016 at 4:28 PM, Amit Kapila <amit.kapila16@gmail.com> wrote:
I found one more problem with patch.

! UnlockReleaseBuffer(buffer);
! RecordPageWithFreeSpace(relation, BufferGetBlockNumber(buffer), freespace);

You can't call BufferGetBlockNumber(buffer) after releasing
the pin on buffer which will be released by
UnlockReleaseBuffer().  Get the block number before unlocking
the buffer.

Good catch, will fix this also in next version.


--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Re: Relation extension scalability
Next
From: Corey Huinker
Date:
Subject: Re: Add generate_series(date,date) and generate_series(date,date,integer)