On Wed, Jun 9, 2021 at 4:12 PM Dilip Kumar <dilipbalaut@gmail.com> wrote: >> Few comments: >> 1. The test has a lot of similarities and test duplication with what >> we are doing in insert-conflict-specconflict.spec. Can we move it to >> insert-conflict-specconflict.spec? I understand that having it in >> test_decoding has the advantage that we can have all decoding tests in >> one place but OTOH, we can avoid a lot of test-code duplication if we >> add it in insert-conflict-specconflict.spec. >> > > It seems the isolation test runs on the default configuration, will it be a good idea to change the wal_level to logical for the whole isolation tester folder? >
No, that doesn't sound like a good idea to me. Let's keep it in test_decoding then.
Okay, I will work on the remaining comments and back patches and send it by tomorrow.
