On Tue, Jan 8, 2019 at 2:11 PM Amit Kapila <amit.kapila16@gmail.com> wrote: 3. + work_txn.urec_next = uur->uur_next; + work_txn.urec_xidepoch = uur->uur_xidepoch; + work_txn.urec_progress = uur->uur_progress; + work_txn.urec_prevurp = uur->uur_prevurp; + work_txn.urec_dbid = uur->uur_dbid; It would be better if we initialize these members in the order in which they appear in the actual structure. All other undo header structures are initialized that way, so this looks out-of-place.
3. + work_txn.urec_next = uur->uur_next; + work_txn.urec_xidepoch = uur->uur_xidepoch; + work_txn.urec_progress = uur->uur_progress; + work_txn.urec_prevurp = uur->uur_prevurp; + work_txn.urec_dbid = uur->uur_dbid; It would be better if we initialize these members in the order in which they appear in the actual structure. All other undo header structures are initialized that way, so this looks out-of-place.
pgsql-hackers by date:
Соглашаюсь с условиями обработки персональных данных
