Re: Gather performance analysis - Mailing list pgsql-hackers

From Dilip Kumar
Subject Re: Gather performance analysis
Date
Msg-id CAFiTN-t1UQVx4RwYVxyEMEn1Cvg1BpMoFAWB+dG=SQFaD6_HJw@mail.gmail.com
Whole thread Raw
In response to Re: Gather performance analysis  (Zhihong Yu <zyu@yugabyte.com>)
List pgsql-hackers
On Sat, Aug 28, 2021 at 5:04 PM Zhihong Yu <zyu@yugabyte.com> wrote:
>

>>
>>  * mqh_partial_bytes, mqh_expected_bytes, and mqh_length_word_complete
>>
>> +   Size        mqh_send_pending;
>>     bool        mqh_length_word_complete;
>>     bool        mqh_counterparty_attached;
>>
>> I wonder if mqh_send_pending should be declared after mqh_length_word_complete - this way, the order of fields
matchesthe order of explanation for the fields.
 

Moved it after mqh_consume_pending and moved comment as well in the
correct order.
>
> There  was a typo in suggested code above. It should be:
>
> +   if (force_flush || mqh->mqh_send_pending > (mq->mq_ring_size >> 2))

Done


-- 
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

Attachment

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: [Proposal] Global temporary tables
Next
From: Heikki Linnakangas
Date:
Subject: Re: Split xlog.c