Re: Concurrency bug in UPDATE of partition-key - Mailing list pgsql-hackers

From Dilip Kumar
Subject Re: Concurrency bug in UPDATE of partition-key
Date
Msg-id CAFiTN-svokoE++NJ0HBY0-E7XRir7WAQrbsOjO147-w9NJhF=w@mail.gmail.com
Whole thread Raw
In response to Re: Concurrency bug in UPDATE of partition-key  (Amit Khandekar <amitdkhan.pg@gmail.com>)
Responses Re: Concurrency bug in UPDATE of partition-key
List pgsql-hackers
On Mon, Jun 18, 2018 at 6:19 PM, Amit Khandekar <amitdkhan.pg@gmail.com> wrote:
> On 18 June 2018 at 17:56, Amit Kapila <amit.kapila16@gmail.com> wrote:
>> On Mon, Jun 18, 2018 at 11:28 AM, Dilip Kumar <dilipbalaut@gmail.com> wrote:
>>> Should we also create a test case where we can verify that some
>>> unnecessary or duplicate triggers are not executed?
>>>
>>
>> I am not sure how much value we will add by having such a test.  In
>> general, it is good to have tests that cover various aspects of
>> functionality, but OTOH, we have to be careful to not overdo it.
>
> Actually I am thinking, it's not a big deal adding a RAISE statement
> in trigger function in the existing testcases. It will clearly show how
> many times the trigger has executed. So I will go ahead and do that.

Ok,  That makes sense to me.

-- 
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Re: Adding tests for inheritance trees with temporary tables
Next
From: Dent John
Date:
Subject: Re: Query Rewrite for Materialized Views (Postgres Extension)