Postgres Pro
Downloads
Home   >   mailing lists

Re: Move pg_attribute.attcompression to earlier in struct for reduced size? - Mailing list pgsql-hackers

From Dilip Kumar
Subject Re: Move pg_attribute.attcompression to earlier in struct for reduced size?
Date
Msg-id CAFiTN-srAVSA9wZvhi_z-q6XR_4b=CAC+bswAdGeurwLFqzuvA@mail.gmail.com
Whole thread Raw
In response to Re: Move pg_attribute.attcompression to earlier in struct for reduced size?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view 
On Fri, May 21, 2021 at 8:31 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
>
>     if (rel->rd_rel->relkind == RELKIND_RELATION ||
>         rel->rd_rel->relkind == RELKIND_PARTITIONED_TABLE)
>
> This seems fairly nuts; in particular, why are matviews excluded?

The matviews are excluded only in "ATExecAddColumn()" right?  But we
can not ALTER TABLE ADD COLUMN to matviews right?  I agree that even
if we don't skip matview it will not create any issue as matview will
not reach here.  Am I missing something?

-- 
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Logical Replication - behavior of TRUNCATE ... CASCADE
Next
From: Dilip Kumar
Date:
Subject: Re: Move pg_attribute.attcompression to earlier in struct for reduced size?