Re: Track statistics for streaming of in-progress transactions - Mailing list pgsql-hackers

From Dilip Kumar
Subject Re: Track statistics for streaming of in-progress transactions
Date
Msg-id CAFiTN-sieF+0wX04AZLH3QNkBPnbLH9qXdg8drYuFmo1e6RY2g@mail.gmail.com
Whole thread Raw
In response to Track statistics for streaming of in-progress transactions  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: Track statistics for streaming of in-progress transactions  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Wed, Oct 14, 2020 at 9:09 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> Commit 464824323e has added the support of the streaming of
> in-progress transactions into the built-in logical replication. The
> attached patch adds the statistics about transactions streamed to the
> decoding output plugin from ReorderBuffer.

I have reviewed the attached patch, I have one comment

+ int64 streamTxns; /* number of transactions streamed to the decoding
output plugin */
+ int64 streamCount; /* streaming invocation counter */
+ int64 streamBytes; /* amount of data streamed to subscriber */

I think instead of saying "amount of data streamed to subscriber"  it
should be " amount of data streamed to the decoding output plugin"

-- 
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: [Patch] Optimize dropping of relation buffers using dlist
Next
From: Julien Rouhaud
Date:
Subject: Re: [patch] Fix checksum verification in base backups for zero page headers