Postgres Pro
Downloads
Home   >   mailing lists

Re: [RM2074][[RM2080]][pgAdmin4] handle large bytea and bytea[] data in datagrid - Mailing list pgadmin-hackers

From Harshal Dhumal
Subject Re: [RM2074][[RM2080]][pgAdmin4] handle large bytea and bytea[] data in datagrid
Date
Msg-id CAFiP3vyJWZ8ZawkjdrPWB7XPiOdg9StbZNYJzKMknYd1y74rQg@mail.gmail.com
Whole thread Raw
In response to Re: [RM2074][[RM2080]][pgAdmin4] handle large bytea and bytea[] datain datagrid  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
Responses Re: [RM2074][[RM2080]][pgAdmin4] handle large bytea and bytea[] datain datagrid  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Tree view
Hi,

Please find updated patch. Now placeholder string for bytea and bytea[] data will only appear in datagrid (view all/1000/500 rows). If user executes query using Query tool then placeholder won't appear (similar to  pgAdminIII behaviour)

-- 
Harshal Dhumal
Sr. Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jul 14, 2017 at 7:23 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Harshal,

This broke the fetching trigger function parameters logic, take a look at raise_a_notice() function parameter in screenshot.

In my opinion we just can't just blindly convert everything to place holder, what if user wants to perform some operation on bytea column like we are doing in web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/trigger/sql/default/properties.sql to fetch these arguments?

Inline image 1

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jul 14, 2017 at 6:43 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

Please find attached patch to handle bytea and bytea[] data in datagrid.

Now instead of showing actual data we can show placeholders like <binary data> and <binary data[]>. Also placeholders will only appear if data actually exists otherwise null will be shown.


-- 
Harshal Dhumal
Sr. Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Attachment

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: [pgadmin-hackers][pgaweb][patch] Website patch to add SCSS
Next
From: Khushboo Vashi
Date:
Subject: [pgAdmin4][Patch]: RM #2556: Runtime connection retry loop timeout