Re: -d option for pg_isready is broken - Mailing list pgsql-hackers

From Fabrízio de Royes Mello
Subject Re: -d option for pg_isready is broken
Date
Msg-id CAFcNs+rSmgV389Eo7kSUiNrTKet4cpc=aoSXgXGXm4-Q5OoR8A@mail.gmail.com
Whole thread Raw
In response to -d option for pg_isready is broken  (Josh Berkus <josh@agliodbs.com>)
Responses Re: -d option for pg_isready is broken  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers

On Wed, Nov 13, 2013 at 9:37 PM, Josh Berkus <josh@agliodbs.com> wrote:

handyrep@john:~/handyrep$ pg_isready --version
pg_isready (PostgreSQL) 9.3.1

handyrep@john:~/handyrep$ pg_isready -h john -p 5432 -U postgres -d
postgres -q
pg_isready: missing "=" after "postgres" in connection info string

handyrep@john:~/handyrep$ pg_isready --host=john --port=5432
--user=postgres --dbname=postgres
pg_isready: missing "=" after "postgres" in connection info string

handyrep@john:~/handyrep$ pg_isready -h john -p 5432 -U postgres
john:5432 - accepting connections

so apparently the -d option:

a) doesn't work, and
b) doesn't do anything

I suggest simply removing it from the utility.

I'll note that the -U option doesn't appear to do anything relevant
either, but at least it doesn't error unnecessarily:

handyrep@john:~/handyrep$ pg_isready -h john -p 5432 -U no_such_user
john:5432 - accepting connections


The attached patch fix it.

Regards,

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
Attachment

pgsql-hackers by date:

Previous
From: Nigel Heron
Date:
Subject: Re: review: autovacuum_work_mem
Next
From: Peter Eisentraut
Date:
Subject: Re: pre-commit triggers