Re: Add pg_freespacemap extension sql test - Mailing list pgsql-hackers

From Fabrízio de Royes Mello
Subject Re: Add pg_freespacemap extension sql test
Date
Msg-id CAFcNs+r-2R0+XzscJxtHQO3miRTbaqoovLTQkXQ_j_sUO=woGg@mail.gmail.com
Whole thread Raw
In response to Re: Add pg_freespacemap extension sql test  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Add pg_freespacemap extension sql test  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers


On Wed, Mar 23, 2022 at 3:05 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> After review, I don't like much the idea of allowing concurrent
> autovacuums to run in parallel of the table(s) of this test, so we'd
> better disable it explicitely.

Make sense.

>  "t1" is also a very generic name to use in a regression test.

Agreed!

>  Another thing that itched me is that we
> could also test more with indexes, particularly with btree, BRIN and
> hash (the latter should not have a FSM with 10 pages as per the first
> group batch, and each one has a stable an initial state).

What about GIN/GIST indexes?

> I have extended the set of tests as of the attached, running these
> across everything I could (CI, all my hosts including Windows, macos,
> Linux).  We could do more later, of course, but this looks enough to
> me as a first step.  And I think that this will not upset the
> buildfarm.

Also LGTM.

Regards,

--
Fabrízio de Royes Mello

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints
Next
From: Tom Lane
Date:
Subject: Re: clean up test_rls_hooks module