Re: Space missing from EXPLAIN output - Mailing list pgsql-hackers

From Fabrízio de Royes Mello
Subject Re: Space missing from EXPLAIN output
Date
Msg-id CAFcNs+qvagUy23M=DYwPa9jXFPFGz3L4-RfQysd_z_Ug=CQwXw@mail.gmail.com
Whole thread Raw
In response to Space missing from EXPLAIN output  (Thom Brown <thom@linux.com>)
Responses Re: Space missing from EXPLAIN output
List pgsql-hackers

On Fri, Feb 28, 2025 at 1:38 PM Thom Brown <thom@linux.com> wrote:
Hi,

Commit ddb17e387aa introduced fractional row counts, but the rejigging
has introduced a formatting issue:

Worker 0:  actual time=34.779..34.780rows=0 loops=1
  Buffers: shared hit=1200
Worker 1:  actual time=39.737..39.738rows=0 loops=1
  Buffers: shared hit=1084

A space is missing between the time values and the "rows" label.


Are you sure your main is updated? The current main is 424ededc580b03e1bcf8aff18a735e519c80061f.

Because your patch is not applying:
main on  main [$]
➜ git apply /tmp/fix_explain_analyze_spacing.diff        
error: patch failed: src/backend/commands/explain.c:2075
error: src/backend/commands/explain.c: patch does not apply

On the current main your change should be on line 2041 and not 2075 according to your patch.

Regards,

--
Fabrízio de Royes Mello

pgsql-hackers by date:

Previous
From: Maxim Orlov
Date:
Subject: Re: Proposal: Limitations of palloc inside checkpointer
Next
From: Tom Lane
Date:
Subject: Re: Licence preamble update