Re: pg_dump bug for extension owned tables - Mailing list pgsql-hackers

From Fabrízio de Royes Mello
Subject Re: pg_dump bug for extension owned tables
Date
Msg-id CAFcNs+q5-cSMg9nP03FKfCvw7OiOCRP9CBJsDT57pyHb9QwfDw@mail.gmail.com
Whole thread Raw
In response to Re: pg_dump bug for extension owned tables  (Fabrízio de Royes Mello <fabriziomello@gmail.com>)
Responses Re: pg_dump bug for extension owned tables
Re: pg_dump bug for extension owned tables
List pgsql-hackers

On Fri, Jun 26, 2020 at 11:55 AM Fabrízio de Royes Mello <fabriziomello@gmail.com> wrote:
>
>
> On Fri, Jun 26, 2020 at 11:24 AM Andrew Dunstan <andrew.dunstan@2ndquadrant.com> wrote:
> >
> >
> > On 6/26/20 9:57 AM, Andrew Dunstan wrote:
> > > It appears that for extension owned tables tbinfo.attgenerated isn't
> > > being properly populated, so line 2050 in REL_12_STABLE, which is line
> > > 2109 in git tip, is failing.
> > >
> > >
> >
> > Should have mentioned this is in src/bin/pg_dump/pg_dump.c
> >
>
> Having a look on it.
>

Seems when qualify the schemaname the the "tbinfo->interesting" field is not setted for extensions objects, so the getTableAttrs can't fill the attgenerated field properly.

I'm not 100% sure it's the correct way but the attached patch works for me and all tests passed. Maybe we should add more TAP tests?

Regards,

--
   Fabrízio de Royes Mello         Timbira - http://www.timbira.com.br/
   PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento
Attachment

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: Default setting for enable_hashagg_disk
Next
From: Alvaro Herrera
Date:
Subject: Re: PG 13 release notes, first draft